feat: update phpdocumentor to 4.0 #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
bshaffer
commented
May 25, 2021
| // @TODO: Modified the following line so that "{}" is not replaced | ||
| // with "}". So far we have not seen any adverse effects | ||
| // $tokens[$i] = str_replace(['{@}', '{}', '%'], ['@', '}', '%%'], $tokens[$i]); | ||
| $tokens[$i] = str_replace(['{@}', '%'], ['@', '%%'], $tokens[$i]); |
There was a problem hiding this comment.
This entire class is here because I need to override this line.... otherwise, {} gets converted to } and never gets changed back. I opened an issue , which results in a host of issues. Removing it does not seem to have adverse effects.
I've filed an issue here: phpDocumentor/ReflectionDocBlock#276
1 task
dwsupplee
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows documentation to be generated for PHP 7.0-only clients (such as
google/cloud-compute)Summary of changes:
phpdocumentor/reflection 4.0before generating the docs (a bit hackish unfortunately).DocGeneratorto use the new API for reflection