feat: inject database info on list databases #2656
Merged
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
approved these changes
Jan 30, 2020
Spanner/src/Database.php
Outdated
| @@ -183,14 +183,16 @@ public function __construct( | |||
| $projectId, | |||
| $name, | |||
| SessionPoolInterface $sessionPool = null, | |||
| $returnInt64AsObject = false | |||
| $returnInt64AsObject = false, | |||
| array $info = null | |||
There was a problem hiding this comment.
You could default the array in the signature here, instead of needing the elvis operator on line 195
Suggested change
| array $info = null | |
| array $info = [] |
jdpedrie
changed the title
jdpedrie
approved these changes
Feb 4, 2020
This was referenced Feb 5, 2020
Merged
Closed
This was referenced Feb 13, 2020
This was referenced Feb 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2524