Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iam): support iam conditions #2416

Merged
merged 38 commits into from
Feb 5, 2020
Merged

feat(iam): support iam conditions #2416

merged 38 commits into from
Feb 5, 2020

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Oct 15, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2019
@jkwlui jkwlui changed the title feat: IAM Conditions/Proposal 2 feat: iam conditions/proposal 2 Oct 15, 2019
@jkwlui jkwlui mentioned this pull request Oct 15, 2019
Closed
@jdpedrie
Copy link
Contributor

@jkwlui is this ready for review?

@jkwlui jkwlui changed the title feat: iam conditions/proposal 2 feat: iam conditions Dec 26, 2019
@jkwlui
Copy link
Member Author

jkwlui commented Dec 30, 2019 •
edited

Kokoro is complaining about missing snippets: NOTICE: 1 uncovered snippets! Otherwise, the tests are clear.

@dwsupplee would you be able to take a look?

@jkwlui jkwlui changed the title feat: iam conditions feat(iam): support iam conditions Dec 30, 2019
dwsupplee
dwsupplee reviewed Feb 4, 2020
View reviewed changes
Storage/src/Bucket.php Outdated Show resolved Hide resolved
dwsupplee
dwsupplee approved these changes Feb 4, 2020
View reviewed changes
Core/src/Iam/PolicyBuilder.php Outdated Show resolved Hide resolved
Storage/tests/System/IamTest.php Outdated Show resolved Hide resolved
jkwlui and others added 2 commits February 4, 2020 16:17
@jkwlui @dwsupplee
Update Storage/tests/System/IamTest.php
59445e6 
Co-Authored-By: David Supplee <dwsupplee@gmail.com>
@jkwlui @dwsupplee
Update Core/src/Iam/PolicyBuilder.php
e38265b 
Co-Authored-By: David Supplee <dwsupplee@gmail.com>
@jkwlui
Copy link
Member Author

jkwlui commented Feb 5, 2020

@dwsupplee thank you so much for your help!

@dwsupplee dwsupplee merged commit ddc58ee into googleapis:master Feb 5, 2020
This was referenced Feb 5, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Feb 13, 2020
Merged
Closed
This was referenced Feb 21, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jkwlui @jdpedrie @frankyn @dwsupplee @googlebot