Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gax redeclared as imported package name #681

Closed
jcgregorio opened this issue Jun 26, 2017 · 2 comments
Closed

gax redeclared as imported package name #681

jcgregorio opened this issue Jun 26, 2017 · 2 comments
Assignees

Comments

@jcgregorio
Copy link

This CL cb38488 introduced a second 'gax' definition in the file:

https://github.com/GoogleCloudPlatform/google-cloud-go/blob/master/pubsub/service.go#L31

Now importing this package gives:

../../cloud.google.com/go/pubsub/service.go:31: gax redeclared as imported package name previous declaration at ../../cloud.google.com/go/pubsub/service.go:25

@jba
Copy link
Contributor

jba commented Jun 26, 2017

Probably due to a bad merge.

Fixed by 2cbf161.

@jcgregorio
Copy link
Author

Thanks!

@jba jba closed this as completed Jun 26, 2017
yoshi-automation added a commit that referenced this issue Nov 13, 2021
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#718

Changes:

fix(compute): Move compute_small protos under its own directory (#681)
  * fix: Move compute_small protos under its own directory

  This is needed to fix API index.
  Also removed gapic_yaml file, as it is not needed anymore.

  * add README.md

  * fix typos

  * fix typos
  Source-Link: googleapis/googleapis@97cabab

feat(pubsublite): add C++ rules for Pub/Sub Lite
  PiperOrigin-RevId: 409506444
  Source-Link: googleapis/googleapis@2c411a8

docs(channel): Small clarification
  PiperOrigin-RevId: 409501969
  Source-Link: googleapis/googleapis@e03933d

feat(securitycenter): Added mute related APIs, proto messages and fields
  PiperOrigin-RevId: 409484892
  Source-Link: googleapis/googleapis@2de80fe
yoshi-automation added a commit that referenced this issue Nov 15, 2021
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#718

Changes:

fix(compute): Move compute_small protos under its own directory (#681)
  * fix: Move compute_small protos under its own directory

  This is needed to fix API index.
  Also removed gapic_yaml file, as it is not needed anymore.

  * add README.md

  * fix typos

  * fix typos
  Source-Link: googleapis/googleapis@97cabab

feat(pubsublite): add C++ rules for Pub/Sub Lite
  PiperOrigin-RevId: 409506444
  Source-Link: googleapis/googleapis@2c411a8

docs(channel): Small clarification
  PiperOrigin-RevId: 409501969
  Source-Link: googleapis/googleapis@e03933d

feat(securitycenter): Added mute related APIs, proto messages and fields
  PiperOrigin-RevId: 409484892
  Source-Link: googleapis/googleapis@2de80fe
codyoss pushed a commit that referenced this issue Nov 15, 2021
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#718

Changes:

fix(compute): Move compute_small protos under its own directory (#681)
  * fix: Move compute_small protos under its own directory

  This is needed to fix API index.
  Also removed gapic_yaml file, as it is not needed anymore.

  * add README.md

  * fix typos

  * fix typos
  Source-Link: googleapis/googleapis@97cabab

feat(pubsublite): add C++ rules for Pub/Sub Lite
  PiperOrigin-RevId: 409506444
  Source-Link: googleapis/googleapis@2c411a8

docs(channel): Small clarification
  PiperOrigin-RevId: 409501969
  Source-Link: googleapis/googleapis@e03933d

feat(securitycenter): Added mute related APIs, proto messages and fields
  PiperOrigin-RevId: 409484892
  Source-Link: googleapis/googleapis@2de80fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants