Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery/storage/managedwriter/adapt: support packed annotation #6302

Closed
shollyman opened this issue Jul 3, 2022 · 1 comment · Fixed by #6312
Closed

bigquery/storage/managedwriter/adapt: support packed annotation #6302

shollyman opened this issue Jul 3, 2022 · 1 comment · Fixed by #6312
Assignees
@shollyman
Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shollyman
Copy link
Contributor

@shollyman Could you support packed = true annotation in repeated FieldOption? We use StorageSchemaToProto2Descriptor and observed 3 bytes overhead per element on repeated fields in the encoded rows. This would be huge overhead to AppendRows throughput for large arrays.

Originally posted by @tyang020 in #4375 (comment)
@shollyman shollyman self-assigned this Jul 3, 2022
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jul 3, 2022
@shollyman shollyman added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed api: bigquery Issues related to the BigQuery API. labels Jul 3, 2022
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jul 3, 2022
@shollyman
Copy link
Contributor Author

TODO: verify there's no special constraints for the packed annotation in the backend, then add to the schema conversion code in adapt.

ex: if proto2 && mode is repeated and in (scalar_numeric_list) then add the appropriate packed fieldoption to the FieldDescriptorProto

@shollyman shollyman mentioned this issue Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shollyman shollyman

Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bigquery/storage/managedwriter/adapt): support packed field option shollyman/google-cloud-go
1 participant
@shollyman