Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: forget to update include User agent ? #5514

Closed
yamatoya opened this issue Feb 11, 2022 · 1 comment
Closed

spanner: forget to update include User agent ? #5514

yamatoya opened this issue Feb 11, 2022 · 1 comment
Assignees
@rahul2393
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@yamatoya
Copy link

google-cloud-go/spanner/doc.go

Lines 377 to 378 in 498a746

// TODO: We will want to automate the version with a bash script.
const clientUserAgent = "spanner-go/v1.12.0"

You may have forgotten to update the version after it was added in #3465.
The current version is 1.29.0, so I thought this line was correct for spanner-go/v1.29.0.

const clientUserAgent = "spanner-go/v1.29.0"
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Feb 11, 2022
@codyoss codyoss added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 11, 2022
@rahul2393
Copy link
Contributor

Thanks for reporting the issue, This will be fixed by #5515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yamatoya @codyoss @rahul2393