Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): remove instance_name resource label #5461

Merged
merged 2 commits into from Feb 8, 2022
Merged

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Feb 7, 2022

GCE instance resource labels are aligned with https://cloud.google.com/monitoring/api/resources#tag_gce_instance

Fixes #4272

@minherz minherz requested review from a team as code owners February 7, 2022 14:42
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the Cloud Logging API. labels Feb 7, 2022
@minherz minherz merged commit 115385f into main Feb 8, 2022
@minherz minherz deleted the minherz/fix-4272 branch February 8, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging: instance_name label is not valid for GCE Instance Resource
2 participants