Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add net.ErrClosed to default retry #5384

Merged
merged 6 commits into from Jan 25, 2022
Merged

feat(storage): add net.ErrClosed to default retry #5384

merged 6 commits into from Jan 25, 2022
+17 −2

Conversation

BrennaEpp
Copy link
Contributor

@BrennaEpp BrennaEpp commented Jan 20, 2022 •
edited

@BrennaEpp BrennaEpp requested review from a team as code owners January 20, 2022 21:17
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the Cloud Storage API. labels Jan 20, 2022
tritone
tritone reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise LGTM

storage/invoke.go Outdated Show resolved Hide resolved
@BrennaEpp
Copy link
Contributor Author

Had to change how we check for the closed network connection error, please re-review

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 21, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jan 24, 2022
@tritone tritone enabled auto-merge (squash) January 25, 2022 23:07
@tritone tritone merged commit a4801c7 into googleapis:main Jan 25, 2022
@BrennaEpp BrennaEpp deleted the retry-errclosed branch February 8, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: TestRetryConformance failed
2 participants
@BrennaEpp @tritone