Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix nil check in gRPC Reader #5376

Merged
merged 2 commits into from Jan 19, 2022

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jan 19, 2022

GetObjectChecksums() can return nil if no checksums are present,
so we need to check for nil.

This might just be an emulator artifact but it's probably not a bad idea
to have this check regardless.

GetObjectChecksums() can return nil if no checksums are present,
so we need to check for nil.
@tritone tritone requested review from a team as code owners January 19, 2022 00:27
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the Cloud Storage API. labels Jan 19, 2022
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritone tritone merged commit 5e7d722 into googleapis:main Jan 19, 2022
@noahdietz
Copy link
Contributor

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants