Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compute): release 1.0.0 #5328

Merged
merged 3 commits into from Jan 11, 2022
Merged

chore(compute): release 1.0.0 #5328

merged 3 commits into from Jan 11, 2022

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Jan 10, 2022

Promote compute to ga/stable ahead of v1 release.

I used the ! breaking change indicator to precipitate a major version bump.

@noahdietz noahdietz requested a review from a team as a code owner January 10, 2022 22:07
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 10, 2022
@codyoss
Copy link
Member

codyoss commented Jan 10, 2022

I don't think this needs to be a breaking change for release please. If you edit the commit message and touch a file with a whitespace change in the compute dir release-please will take care of this for us and open a PR. https://github.com/googleapis/release-please#how-do-i-change-the-version-number

@noahdietz
Copy link
Contributor Author

I don't think this needs to be a breaking change for release please. If you edit the commit message and touch a file with a whitespace change in the compute dir release-please will take care of this for us and open a PR.

Updated! I removed the beta documentation as my "whitespace change" :) That's the only thing that would change with the beta-> ga switch anyways.

@noahdietz noahdietz changed the title feat(compute)!: promote to GA/stable chore(compute): release 1.0.0 Jan 10, 2022
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Jan 11, 2022
@codyoss codyoss merged commit 5437c12 into googleapis:main Jan 11, 2022
@noahdietz noahdietz deleted the compute-ga branch January 11, 2022 16:31
@release-please release-please bot mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants