Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): pass context into checkOrdering to allow cancel #5316

Merged
merged 6 commits into from Jan 24, 2022
Merged

fix(pubsub): pass context into checkOrdering to allow cancel #5316

merged 6 commits into from Jan 24, 2022

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Jan 8, 2022

Pass in context to checkOrdering function to allow the config call to be cancellable by the user after calling sub.Receive.

Fixes #5224

@hongalex hongalex requested review from a team as code owners January 8, 2022 01:38
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the Pub/Sub API. labels Jan 8, 2022
codyoss
codyoss approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongalex hongalex enabled auto-merge (squash) January 18, 2022 18:06
@hongalex hongalex merged commit fc08c49 into googleapis:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: context cancel is not processed when calling checkOrdering
2 participants
@hongalex @codyoss