Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery/storage/managedwriter): support schema change notification #5253

Merged
merged 6 commits into from Dec 30, 2021

Conversation

shollyman
Copy link
Contributor

This adds a way for user to get schema changes by checking AppendResult.

Related: #5244
Related: #4366

This adds a way for user to get schema changes by checking AppendResult.
@shollyman shollyman requested a review from a team December 23, 2021 20:15
@shollyman shollyman requested a review from a team as a code owner December 23, 2021 20:15
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Dec 23, 2021
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's the "least effort solution" described in #5244, right?

add the updated schema to the AppendResult future, and simply return the schema as a method there.

@shollyman
Copy link
Contributor Author

LGTM. It's the "least effort solution" described in #5244, right?

add the updated schema to the AppendResult future, and simply return the schema as a method there.

That's correct. It may make sense to have a callback in the future, but this allows users to roll their own monitor.

By comparison, java effectively exposes this as a property of the StreamWriter, but there's no way to signal/clear it; users end up needing to recreate a new one.

@shollyman shollyman merged commit 70e40db into googleapis:main Dec 30, 2021
@shollyman shollyman deleted the fr-schemanotification branch December 30, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants