feat(bigtable): add support for autoscaling #5232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
requested review from
crwilcox,
dmahugh,
tritone and
a team
as code owners
product-auto-label
bot
added
the
api: bigtable
|
googleapis/go-genproto#733 has been merged. Should now just need to update the version of genproto being pulled in. |
|
Thanks @codyoss! |
tritone
reviewed
Dec 29, 2021
This commit adds support for autoscaling in the InstanceAdminClient with associated unit tests and a happy-path integration test. When creating either a new instance or cluster, callers may specify an AutoscalingConfig. For existing clusters, to enable autoscaling on a cluster, a caller may use SetAutoscaling. To remove autoscaling, callers may use UpdateCluster. Alternatively, callers may either update the cluster to enable or disable autoscaling with UpdateInstanceWithClusters or UpdateInstanceAndSyncClusters.
Previously UpdateInstanceWithClusters would try to update a cluster even if the NumNodes was 0 (or less), resulting in an erroneous error. This commit ensures a cluster is updated only when a valid and non-zero value of NumNodes is provided.
enocom
force-pushed
the
bigtable-autoscaling
branch
from
aa01df7
to
49b09c9
Compare
|
@telpirion and @tritone PTAL. I've addressed all the comments above. |
kolea2
reviewed
Jan 12, 2022
tritone
reviewed
Jan 14, 2022
There was a problem hiding this comment.
couple more minor comments/questions, overall LGTM. I will leave it to @kolea2 and @telpirion to approve!
kolea2
reviewed
Jan 18, 2022
kolea2
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See googleapis/googleapis@0fd6a32 for details.
Note: this work depends on googleapis/googleapis@0fd6a32 (from Nov. 15) being available in go-genproto. (last updated Nov. 2).