Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(containeranalysis): fix docs and closing of client. #5220

Merged
merged 3 commits into from Jan 10, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 16, 2021

It was documented that the embeded grafeas client shared a connection
with the main client, but it does not and never has from looking at history.
Updated the comment but also explicitly called close on the grafeas client
when the containeranalysis client is closed.

Fixes: #5217

It was documented that the embeded grafeas client shared a connection
with the main client, but it does not and never has from looking at history.
Updated the comment but also explicitly called close on the grafeas client
when the containeranalysis client is closed.

Fixes: googleapis#5217
@codyoss codyoss requested a review from a team as a code owner December 16, 2021 16:02
@product-auto-label product-auto-label bot added the api: containeranalysis Issues related to the Container Analysis API. label Dec 16, 2021
@codyoss codyoss enabled auto-merge (squash) December 21, 2021 16:45
@codyoss codyoss disabled auto-merge January 10, 2022 17:24
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 10, 2022
@codyoss codyoss merged commit e6d4b8d into googleapis:main Jan 10, 2022
@release-please release-please bot mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: containeranalysis Issues related to the Container Analysis API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

containeranalysis: connection is not shared
2 participants