Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): configurable retries for uploads #5210

Merged
merged 8 commits into from Dec 23, 2021
Merged

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Dec 9, 2021

Depends on merge and release of googleapis/google-api-go-client#1324

@tritone tritone requested review from a team as code owners December 9, 2021 20:27
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Dec 9, 2021
@tritone tritone added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 9, 2021
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple comments.

This should make the objects.insert conformance tests pass, correct (once everything is merged)? If so then we should update the ci as well

storage/writer.go Outdated Show resolved Hide resolved
tritone added a commit to tritone/google-cloud-go that referenced this pull request Dec 20, 2021
This test fails with the updated version of the apiary library,
but it will be re-enabled with a fix in googleapis#5210.
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 20, 2021
This test fails with the updated version of the apiary library,
but it will be re-enabled with a fix in #5210.
BrennaEpp pushed a commit to BrennaEpp/google-cloud-go that referenced this pull request Dec 23, 2021
This test fails with the updated version of the apiary library,
but it will be re-enabled with a fix in googleapis#5210.
@tritone tritone removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 23, 2021
@tritone tritone requested review from BrennaEpp and a team December 23, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants