feat(storage): add retry config to the Client and HmacKey operations #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
tritone
reviewed
Dec 13, 2021
tritone
reviewed
Dec 14, 2021
storage/hmac.go
Outdated
| @@ -214,7 +215,12 @@ func (c *Client) CreateHMACKey(ctx context.Context, projectID, serviceAccountEma | |||
|
|
|||
| setClientHeader(call.Header()) | |||
|
|
|||
| hkPb, err := call.Context(ctx).Do() | |||
| var hkPb *raw.HmacKey | |||
| var err error | |||
There was a problem hiding this comment.
Can inline this declaration
storage/hmac.go
Outdated
| metadata, err = call.Context(ctx).Do() | ||
| return err | ||
| }) | ||
| }, h.retry, true) |
There was a problem hiding this comment.
This should be conditionally idempotent based on whether the Etag is present in the metadata-- the user may pass it in HMACKeyAttrsToUpdate or not.
Are conformance tests catching this?
There was a problem hiding this comment.
It should be good now
tritone
approved these changes
Dec 20, 2021
storage/retry_conformance_test.go
Outdated
| if err != nil { | ||
| return err | ||
| if preconditions { | ||
| k, err := key.Get(ctx) |
There was a problem hiding this comment.
I think you can get Etag from fs.hmacKey rather than having another Get
tritone
approved these changes
Dec 20, 2021
BrennaEpp
added a commit
to BrennaEpp/google-cloud-go
that referenced
this pull request
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.