Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): retry copy funcs on idempotent conds #5172

Merged
merged 4 commits into from Nov 29, 2021
Merged

feat(storage): retry copy funcs on idempotent conds #5172

merged 4 commits into from Nov 29, 2021

Conversation

BrennaEpp
Copy link
Contributor

@BrennaEpp BrennaEpp commented Nov 26, 2021 •
edited

retry objects.compose and objects.rewrite on idempotent conditions

@BrennaEpp BrennaEpp requested review from a team as code owners November 26, 2021 06:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 26, 2021
@BrennaEpp BrennaEpp changed the title feat(storage): retry objects.compose on idempotent conds feat(storage): retry copy funcs on idempotent conds Nov 26, 2021
tritone
tritone reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankyn could you double check the idempotency conditions on these? Just wanted to confirm that checking these conditions specifically on the destination object is correct for rewrite and compose.

tritone
tritone approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually yes confirmed that this is correct-- see googleapis/python-storage#454 for the python equivalent.

@BrennaEpp BrennaEpp enabled auto-merge (squash) November 29, 2021 20:40
@BrennaEpp BrennaEpp merged commit 6d09687 into googleapis:main Nov 29, 2021
@BrennaEpp BrennaEpp deleted the retry-object-compose branch November 29, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrennaEpp @tritone