Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): allow retry ErrorFunc configs #5166

Merged
merged 2 commits into from Nov 24, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Nov 23, 2021

Allows users to supply a custom ErrorFunc which will be used
to determine whether the error is retryable.

Allows users to supply a custom ErrorFunc which will be used
to determine whether the error is retryable.
@tritone tritone requested review from a team as code owners November 23, 2021 23:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 23, 2021
@tritone tritone merged commit c103ff6 into googleapis:main Nov 24, 2021
@tritone tritone deleted the should-retry branch November 24, 2021 20:09
asthamohta pushed a commit to asthamohta/google-cloud-go that referenced this pull request Dec 7, 2021
Allows users to supply a custom ErrorFunc which will be used
to determine whether the error is retryable.
asthamohta added a commit that referenced this pull request Jan 4, 2022
…5199)

* feat(storage): allow retry ErrorFunc configs (#5166)

Allows users to supply a custom ErrorFunc which will be used
to determine whether the error is retryable.

* Changes in test case

* feat: changes to tests

* feat: fixes for errors

* featt: changes to imports

* feat: linting changes

* fix: changes as per review

* fix: changes as per review

* fix: changes as per review

* fix: changes as per review

Co-authored-by: Chris Cotter <cjcotter@google.com>
Co-authored-by: rahul2393 <rahulyadavsep92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants