feat(storage): add retry idempotency configs #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds idempotency options to ObjectHandle.Retryer. This allows users to choose whether only idempotent operations are retried (default), all operations are retried, or nothing is retried. In addition, change ObjectHandle.Update and ObjectHandle.Delete to retry only when idempotency conditions are present by default.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
noahdietz
approved these changes
Nov 23, 2021
ddelgrosso1
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds idempotency options to ObjectHandle.Retryer. This allows
users to choose whether only idempotent operations are retried
(default), all operations are retried, or nothing is retried.
In addition, change ObjectHandle.Update and ObjectHandle.Delete
to retry only when idempotency conditions are present by default.