New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add retry configurability #5159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds configurability for how/whether the library will retry operations. This PR is limited to ObjectHandle methods and configuration only of backoff timing; however I plan on expanding this to additional settings (using the same RetryOption framework) and to all methods which make network calls (via adding Retryer methods to BucketHandle, etc).
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 18, 2021
product-auto-label
bot
added
the
api: storage
Issues related to the Cloud Storage API.
label
Nov 18, 2021
noahdietz
reviewed
Nov 18, 2021
noahdietz
approved these changes
Nov 19, 2021
BrennaEpp
reviewed
Nov 23, 2021
ddelgrosso1
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BrennaEpp
approved these changes
Nov 23, 2021
tritone
added
automerge: exact
Summon MOG for automerging, but approvals need to be against the latest commit
automerge
Merge the pull request once unit tests and other checks pass.
and removed
automerge: exact
Summon MOG for automerging, but approvals need to be against the latest commit
labels
Nov 23, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the Cloud Storage API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configurability for how/whether the library will retry
operations. This PR is limited to ObjectHandle methods and
configuration only of backoff timing; however I plan on expanding
this to additional settings (using the same RetryOption framework)
and to all methods which make network calls (via adding Retryer
methods to BucketHandle, etc).