Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add retry configurability #5159

Merged
merged 5 commits into from Nov 23, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Nov 18, 2021

Adds configurability for how/whether the library will retry
operations. This PR is limited to ObjectHandle methods and
configuration only of backoff timing; however I plan on expanding
this to additional settings (using the same RetryOption framework)
and to all methods which make network calls (via adding Retryer
methods to BucketHandle, etc).

Adds configurability for how/whether the library will retry
operations. This PR is limited to ObjectHandle methods and
configuration only of backoff timing; however I plan on expanding
this to additional settings (using the same RetryOption framework)
and to all methods which make network calls (via adding Retryer
methods to BucketHandle, etc).
@tritone tritone requested review from a team as code owners November 18, 2021 20:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 18, 2021
storage/storage_test.go Outdated Show resolved Hide resolved
storage/storage_test.go Outdated Show resolved Hide resolved
storage/invoke.go Outdated Show resolved Hide resolved
Copy link

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritone tritone added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit automerge Merge the pull request once unit tests and other checks pass. and removed automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Nov 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit a12641a into googleapis:main Nov 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 23, 2021
@tritone tritone deleted the retry-config branch November 23, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants