Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): GenerateSignedPostPolicyV4 can use existing creds to authenticate #5105

Merged
merged 9 commits into from Dec 1, 2021
Merged

feat(storage): GenerateSignedPostPolicyV4 can use existing creds to authenticate #5105

merged 9 commits into from Dec 1, 2021
+138 −5

Conversation

BrennaEpp
Copy link
Contributor

Parallel change to #4604 - this implements the same functionality for generating signed post policies.

Users can omit filling in GoogleAccessID, PrivateKey, and SignRawBytes if they are okay with default values for these.

  • adds a test for this method
  • changes existing tests to use this method as it wraps the original
  • adds a bit more logging to mustDeleteObject

@BrennaEpp BrennaEpp requested review from a team as code owners November 10, 2021 03:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 10, 2021
@BrennaEpp BrennaEpp enabled auto-merge (squash) November 11, 2021 17:37
tritone
tritone reviewed Nov 12, 2021
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

storage/post_policy_v4.go Show resolved Hide resolved
storage/integration_test.go Outdated Show resolved Hide resolved
tritone
tritone approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @codyoss could you take a look as well before we merge?

@BrennaEpp BrennaEpp merged commit 46489f4 into googleapis:main Dec 1, 2021
@BrennaEpp BrennaEpp deleted the signedpost branch March 23, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@codyoss codyoss Awaiting requested review from codyoss

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrennaEpp @tritone