feat(bigtable/spanner): add google-c2p dependence to bigtable and spanner #5090
Conversation
mohanli-ml
requested review from
crwilcox,
dmahugh,
enocom,
hengfengli,
skuruppu,
tritone and
a team
as code owners
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigtable
|
Please note that this does seem to carry a large amount of new dependencies. Open to other suggestions but I think it is at least better to limit the scope of these to the clients using the feature rather than being on the hot-path for all clients. |
|
As the plan is that CBT/Spanner will use DirectPath by default, we will eventually add the google-c2p dependencies to CBT/Spanner client repo, so I guess it does not harm to do it now? |
|
I don't see this PR introduces more dependencies in Spanner. LGTM. |
This comment has been minimized.
This comment has been minimized.
|
Hello. Is this ready to be merged? It appears to be required for googleapis/google-api-go-client#1283. |
|
@codyoss I run |
|
@mohanli-ml I think are Spanner lib does its own gRPC connection handling to support session/transaction affinity IIRC. It may be that the client already relied on an additional gRPC package so it does not have more new code to pull in. This is a guess without looking at the code. |
|
Hello. Any progress here? |
|
@codyoss Can you help to approve and merge this PR? Thanks! |
Remove google-c2p dependency to the entire google-api-go-client. Instead, services using DirectPath should add the dependency by itself, like googleapis/google-cloud-go#5090. Issue: #1283
…nner (googleapis#5090) According to discussion in googleapis/google-api-go-client#1283, we plan to move the google-c2p dependence to bigtable/spanner, which are services that will use DirectPath. feat(bigtable): add google-c2p dependence feat(spanner): add google-c2p dependence
According to discussion in googleapis/google-api-go-client#1283, we plan to move the google-c2p dependence to bigtable/spanner, which are services that will use DirectPath.
feat(bigtable): add google-c2p dependence
feat(spanner): add google-c2p dependence