feat(bigquery/storage/managedwriter): extend managedstream to support call options #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plumbs the ability to pass gax.CallOption opts to the underlying client underpinning the ManagedStream. It also adds a WithAppendRowsCallOption option to the constructor, as well as adding direct option passing for operations like Finalize() and FlushRows(). Towards: googleapis#4366
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
shollyman
requested review from
codyoss and
tswast
and removed request for
stephaniewang526
codyoss
approved these changes
Nov 4, 2021
tswast
approved these changes
Nov 4, 2021
Added the "BREAKING CHANGE:" stanza to the description |
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: changes function signatures to add variadic call options
This plumbs the ability to pass gax.CallOption opts to the
underlying client underpinning the ManagedStream. It also
adds a WithAppendRowsCallOption option to the constructor,
as well as adding direct option passing for operations like
Finalize() and FlushRows().
Towards: #4366