feat(bigquery): expose identifiers using a variety of formats #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an Identifier() method to common BQ resources so that users can get an identifier that is formatted appropriately for their use case (legacy sql, standard sql, referencing in storage API, etc). Existing instances of FullyQualifiedName() have been migrated to the new method. Fixes: googleapis#1955
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
tswast
approved these changes
Oct 25, 2021
Tables have special case behavior for quoting that obviates need for quoting, and BQML seems to want to quote the entire identifier, not the individual parts. Cited in the comments. Annnnnd you weren't asking a question, misread this. |
shollyman
added
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Identifier() method to common BQ resources so
that users can get an identifier that is formatted appropriately
for their use case (legacy sql, standard sql, referencing in storage
API, etc).
Existing instances of FullyQualifiedName() have been migrated to the
new method.
Fixes: #1955