feat(storage): add rpo (turbo replication) support #5003
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
BrennaEpp
added
the
do not merge
storage/bucket.go
Outdated
|
|
||
| // RPODefault is used to reset RPO on an existing bucket with RPO set to RPOAsyncTurbo. | ||
| // Otherwise RPODefault is equivalent to the RPO field being absent, and is always ignored | ||
| RPODefault RPO = iota |
There was a problem hiding this comment.
Can RPO be set to default? If so, I think we'd need another unknown-type value to be the zero value. Zeros do not propagate through to the service generally. And I think we'd want to distinguish in bucket attrs between DEFAULT vs. an unknown value (if there is a new enum addition) and/or nothing being returned for that field.
See what I have for PublicAccessPrevention, I'm assuming this should probably operate the same way.
There was a problem hiding this comment.
Just for some clarity, in the case of a single region bucket, RPO will not be present in the metadata. For a multiregion bucket, RPO will always come back as DEFAULT.
There was a problem hiding this comment.
Good note, I've changed this as suggested.
There was a problem hiding this comment.
Code looks good now; a couple docs comments.
Also @ddelgrosso1 , do we need an integration test for this feature?
product-auto-label
bot
added
the
stale: extraold
BrennaEpp
removed
the
do not merge
Fixes #4911