Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner/spannertest): implement RowDeletionPolicy in spannertest #4961

Merged
merged 4 commits into from Oct 8, 2021
Merged

feat(spanner/spannertest): implement RowDeletionPolicy in spannertest #4961

merged 4 commits into from Oct 8, 2021

Conversation

olavloite
Copy link
Contributor

Fixes #4782

@olavloite olavloite requested review from skuruppu and a team as code owners October 7, 2021 08:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2021
@olavloite olavloite changed the title feat: implement RowDeletionPolicy in spannertest feat(spanner/spannertest): implement RowDeletionPolicy in spannertest Oct 7, 2021
rahul2393
rahul2393 approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@rahul2393 rahul2393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@olavloite olavloite removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2021
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Oct 8, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7800a33 into master Oct 8, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the spannertest-row-deletion-policy branch October 8, 2021 05:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@rahul2393 rahul2393 rahul2393 approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spannertest: add support for row deletion policy
4 participants
@olavloite @hengfengli @rahul2393 @kokoro-team