Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): prefer exact matches when reflecting fields #4908

Merged
merged 3 commits into from Sep 29, 2021

Conversation

crwilcox
Copy link
Contributor

Fixes #4722 by preferring the best matches in pb value to struct code.

@crwilcox crwilcox requested review from tritone and a team as code owners September 29, 2021 18:42
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Sep 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crwilcox crwilcox merged commit d3d9420 into googleapis:master Sep 29, 2021
@crwilcox crwilcox deleted the chooseBestMatchesProtoReflect branch September 29, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firestore: DataTo() Inconsistent if Field Names Differ by First Character
3 participants