Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal/godocfx): detect preview versions #4899

Merged
merged 1 commit into from Sep 28, 2021
Merged

feat(internal/godocfx): detect preview versions #4899

merged 1 commit into from Sep 28, 2021

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Sep 28, 2021

See b/197007831.

I added unit tests. But, I also confirmed this works on google.golang.org/appengine/v2 (status: preview shows up in the output YAML).

@tbpg tbpg requested a review from codyoss September 28, 2021 15:56
@tbpg tbpg requested a review from a team as a code owner September 28, 2021 15:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2021
codyoss
codyoss approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg merged commit 9b60844 into master Sep 28, 2021
@tbpg tbpg deleted the godocfx branch September 28, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbpg @codyoss