Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal/trace): use xerrors.As for trace #4813

Merged
merged 1 commit into from Sep 27, 2021
Merged

fix(internal/trace): use xerrors.As for trace #4813

merged 1 commit into from Sep 27, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Sep 24, 2021

Based on #4797, we should use xerrors.As for googleapi errors.

@tritone
fix(internal/trace): use xerrors.As for trace
2e95125 
Based on googleapis#4797, we should use xerrors.As for googleapi errors.
@tritone tritone requested a review from a team as a code owner September 24, 2021 20:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2021
codyoss
codyoss approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss merged commit 05fe61c into googleapis:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tritone @codyoss