New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner/spansql): fill in missing hash functions #4808
feat(spanner/spansql): fill in missing hash functions #4808
Conversation
5207d23
to
d6c8d8f
Compare
The `spansql` package is quite useful for parsing and managing schemas, however, with the addition of `CHECK` constraints to the spanner DDL, the full set of SQL functions can now appear in schemas. Fill in the missing Hash functions to support their use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note that this will only add these functions to the list of functions that are recognized as being a function. They will still not return any values, so they cannot be used in queries.
Thanks @olavloite! Yeah, when I glanced at which functions For my use-case, I want to include |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Thanks @hengfengli ! |
@dfinkel No worries. Thank you for your contribution! |
The
spansql
package is quite useful for parsing and managing schemas,however, with the addition of
CHECK
constraints to the spanner DDL,the full set of SQL functions can now appear in schemas.
Fill in the missing Hash functions to support their use.
List of hash functions pulled from: https://cloud.google.com/spanner/docs/hash_functions