Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add projectNumber field to bucketAttrs. #4805

Merged
merged 8 commits into from Sep 28, 2021

Conversation

anrajitha
Copy link
Contributor

Fixes: #4804

Adds ProjectNumber field to bucketAttrs.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2021
@tritone tritone marked this pull request as ready for review September 24, 2021 21:34
@tritone tritone requested review from a team as code owners September 24, 2021 21:34
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good!

storage/bucket.go Show resolved Hide resolved
storage/bucket_test.go Show resolved Hide resolved
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrennaEpp BrennaEpp added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 28, 2021
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 28, 2021
@BrennaEpp BrennaEpp added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 28, 2021
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 28, 2021
@BrennaEpp BrennaEpp merged commit 07343af into googleapis:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: Bucket.go doesn't export projectNumber available in the REST API
4 participants