Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): notify subscriber clients on partition reassignment #4777

Merged
merged 6 commits into from Oct 1, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Sep 20, 2021

  • Adds ReceiveSettings.ReassignmentHandler for the SubscriberClient to receive notifications when the server sends a new partition reassignment to the client. The handler receives previous and new partition numbers.
  • Discards NACKs for messages whose partitions have been assigned away. This prevents unnecessary termination of the SubscriberClient if the default nack handler is used.

@tmdiep tmdiep requested review from a team as code owners September 20, 2021 23:12
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Sep 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2021
@manuelmenzella-google
Copy link

Thanks for addressing the comments!

@tmdiep
Copy link
Contributor Author

tmdiep commented Oct 1, 2021

Thanks for reviewing :)

@tmdiep tmdiep merged commit 393b0a3 into googleapis:master Oct 1, 2021
@tmdiep tmdiep deleted the reassignment_handler branch October 1, 2021 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants