feat(spanner/spansql): Support multiple joins in query #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philwitty
requested review from
hengfengli,
skuruppu and
a team
as code owners
google-cla
bot
added
the
cla: yes
olavloite
reviewed
Sep 13, 2021
| @@ -1109,6 +1109,13 @@ func TestIntegration_ReadsAndQueries(t *testing.T) { | |||
| {int64(4), nil, "p"}, | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
nit: Could we also add a LEFT JOIN test here? I've verified that it does work, but adding a test case could prevent potential regressions in the future.
olavloite
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
olavloite
approved these changes
Sep 14, 2021
olavloite
added
the
automerge
hengfengli
approved these changes
Sep 14, 2021
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3966 is implementing the same functionality (and more) but the author has lost interest and I don't have the knowledge to take over the unnest parts of his PR, I felt my solution to multiple joins is simple enough the other functionality could be rebased on top of it assuming a new owner takes it on.