fix(pubsub): prevent draining error return for Receive #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
codyoss
reviewed
Sep 9, 2021
codyoss
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
receive_scheduler.go, adding a new message after the context passed intoReceiveis cancelled will result in a library-defineddrainingerror. This is poor behavior as the condition which this happens is out of the user's control (simultaneousShutdown+ReceiveScheduler.Add()). This PR mitigates this byIn addition, since it's unlikely for messages to be added, this PR also removes the draining error entirely and allows messages to be added. This is very unlikely and is still preferable to surfacing an unactionable error to the user.
Fixes #4718