fix(storage): align retry idempotency (part 1) #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain non-idempotent operations were being retried by the library, and certain idempotent operations were not. This fixes the following operations: Add retry: notifications.delete, service_account.get Remove retry: bucket_acl.delete, bucket_acl.update, default_object_acl.delete, default_object_acl.update, object_acl.delete, object_acl.update, hmacKey.create Additional PR on conditionally idempotent operations to come.
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
noahdietz
approved these changes
Sep 2, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 29, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.17.0](https://www.github.com/googleapis/google-cloud-go/compare/storage/v1.16.1...storage/v1.17.0) (2021-09-28) ### Features * **storage:** add projectNumber field to bucketAttrs. ([#4805](https://www.github.com/googleapis/google-cloud-go/issues/4805)) ([07343af](https://www.github.com/googleapis/google-cloud-go/commit/07343afc15085b164cc41d202d13f9d46f5c0d02)) ### Bug Fixes * **storage:** align retry idempotency (part 1) ([#4715](https://www.github.com/googleapis/google-cloud-go/issues/4715)) ([ffa903e](https://www.github.com/googleapis/google-cloud-go/commit/ffa903eeec61aa3869e5220e2f09371127b5c393)) This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain non-idempotent operations were being retried by the
library, and certain idempotent operations were not. This
fixes the following operations:
Add retry: notifications.delete, service_account.get
Remove retry: bucket_acl.delete, bucket_acl.update,
default_object_acl.delete, default_object_acl.update,
object_acl.delete, object_acl.update, hmacKey.create
Additional PR on conditionally idempotent operations to come.