Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner/spannertest): Fix the "LIKE" clause handling for forward and backward matches #4655

Merged
merged 2 commits into from Aug 23, 2021
Merged

fix(spanner/spannertest): Fix the "LIKE" clause handling for forward and backward matches #4655

merged 2 commits into from Aug 23, 2021

Conversation

sryoya
Copy link
Contributor

@sryoya sryoya commented Aug 20, 2021

Fixes #4654

@sryoya sryoya requested review from hengfengli, skuruppu and a team as code owners August 20, 2021 14:45
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2021
@codyoss codyoss changed the title fix(spannertest): Fix the "LIKE" clause handling for forward and backward matches fix(spanner/spannertest): Fix the "LIKE" clause handling for forward and backward matches Aug 20, 2021
olavloite
olavloite approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, LGTM

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@hengfengli hengfengli merged commit a2118f0 into googleapis:master Aug 23, 2021
@sryoya sryoya deleted the fix_LIKE_clause_handling_for_prefix_and_suffix branch August 23, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
4 participants
@sryoya @hengfengli @olavloite @kokoro-team