Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): initialize commit sentinel to avoid cross use of commits #4599

Merged
merged 2 commits into from Aug 18, 2021

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Aug 11, 2021

Fixes #4595

This was removed as part of a refactor a few years back I think unintentionally. 01dbcbb#diff-079c68b9cecfc52927852b5c69dca2af9d71a8140b618164c70b5d323c794c66L209

@crwilcox crwilcox requested review from tritone and a team as code owners August 11, 2021 20:06
@product-auto-label product-auto-label bot added the api: datastore Issues related to the Datastore API. label Aug 11, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2021
@crwilcox crwilcox merged commit fcf13b0 into googleapis:master Aug 18, 2021
@crwilcox crwilcox deleted the fix-4595 branch October 29, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datastore: Commit.Key doesn't actually validate the PendingKey is from the right commit
2 participants