fix(bigquery/storage/managedwriter): support non-default regions #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional internal context: b/185842996 Request routing relies on a metadata header being present, but because of the bidi nature library generators don't automatically attach the write stream metadata into x-goog-request-headers. For this API, the stream ID is constant for the whole stream so we inject it when opening the stream, which is when routing needs the information. This causes some minor changes to how we do stream (re)open because we need to pass in the stream ID as part of the function. This change also updates integration testing so that we're testing in an explicit, non-default region (us-east1).
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
yirutang
approved these changes
Aug 6, 2021
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional internal context: b/185842996
Request routing relies on a metadata header being present, but because of the bidi nature
library generators don't automatically attach the write stream metadata
into x-goog-request-headers.
For this API, the stream ID is constant for the whole stream so we
inject it when opening the stream, which is when routing needs the
information.
This causes some minor changes to how we do stream (re)open because
we need to pass in the stream ID as part of the function. This change
also updates integration testing so that we're testing in an explicit,
non-default region (us-east1).
Towards: #4366