feat(bigquery/storage/managedwriter): wire in flow controller #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a flow controller to the managed stream, guarding AppendRows. This change puts the release responsibility for the flow controller in the markDone() method of the pendingWrite. Flow controller code is already well tested via unit tests, so this doesn't add any additional tests.
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
donners
reviewed
Feb 2, 2022
| if err := ms.fc.acquire(ctx, pw.reqSize); err != nil { | ||
| // in this case, we didn't acquire, so don't pass the flow controller reference to avoid a release. | ||
| pw.markDone(NoStreamOffset, err, nil) | ||
| } |
There was a problem hiding this comment.
@shollyman Is there a missing return here? We've observed the following panic, which seems like it could be related to markDone resetting pw.request above before the append call proceeds below.
runtime error: invalid memory address or nil pointer dereference
at cloud.google.com/go/bigquery/storage/managedwriter.(*ManagedStream).append ( /go/src/github.com/ScriptRock/webscan-golang/vendor/cloud.google.com/go/bigquery/storage/managedwriter/managed_stream.go:284 )
at cloud.google.com/go/bigquery/storage/managedwriter.(*ManagedStream).AppendRows ( /go/src/github.com/ScriptRock/webscan-golang/vendor/cloud.google.com/go/bigquery/storage/managedwriter/managed_stream.go:363 )
There was a problem hiding this comment.
Created #5428 to follow up on this. Sheer luck I saw this comment, but looks likely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a flow controller to the managed stream, guarding AppendRows.
This change puts the release responsibility for the flow controller in
the markDone() method of the pendingWrite. Flow controller code is
already well tested via unit tests, so this doesn't add any additional
tests.
Towards: #4366