Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner/spansql): fix unstable SelectFromTable SQL #4473

Merged
merged 1 commit into from Jul 21, 2021
Merged

fix(spanner/spansql): fix unstable SelectFromTable SQL #4473

merged 1 commit into from Jul 21, 2021

Conversation

nktks
Copy link
Contributor

@nktks nktks commented Jul 21, 2021

#4457 made unstable SQL string, and fail test sometimes like this.

--- FAIL: TestSQL (0.00s)
    sql_test.go:410: {{false [A] [{Table  map[FORCE_INDEX:Idx GROUPBY_SCAN_OPTIMIZATION:TRUE]}] {4 B b <nil>} [] [] []} [] <nil> <nil>}.SQL() wrong.
         got SELECT A FROM Table@{GROUPBY_SCAN_OPTIMIZATION=TRUE,FORCE_INDEX=Idx} WHERE B = @b
        want SELECT A FROM Table@{FORCE_INDEX=Idx,GROUPBY_SCAN_OPTIMIZATION=TRUE} WHERE B = @b

Because map range result is unstable.
This PR makes the SQL output stable by sorting the Hints keys.

feat(spanner/spansql): fix unstable SelectFromTable SQL
32364a1 
googleapis#4457 made unstable SQL string, and fail test sometimes like this.
```
--- FAIL: TestSQL (0.00s)
    sql_test.go:410: {{false [A] [{Table  map[FORCE_INDEX:Idx GROUPBY_SCAN_OPTIMIZATION:TRUE]}] {4 B b <nil>} [] [] []} [] <nil> <nil>}.SQL() wrong.
         got SELECT A FROM Table@{GROUPBY_SCAN_OPTIMIZATION=TRUE,FORCE_INDEX=Idx} WHERE B = @b
        want SELECT A FROM Table@{FORCE_INDEX=Idx,GROUPBY_SCAN_OPTIMIZATION=TRUE} WHERE B = @b
```
Because map range result is unstable.
This PR makes the SQL output stable by sorting the Hints keys.
@nktks nktks requested review from hengfengli, skuruppu and a team as code owners July 21, 2021 03:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jul 21, 2021
This was referenced Jul 21, 2021
Closed
Closed
@olavloite olavloite added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 21, 2021
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 21, 2021
@hengfengli hengfengli changed the title feat(spanner/spansql): fix unstable SelectFromTable SQL fix(spanner/spansql): fix unstable SelectFromTable SQL Jul 21, 2021
@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2021
@hengfengli hengfengli merged commit 39bc4ec into googleapis:master Jul 21, 2021
@nktks nktks deleted the fix/spansql-failed-test branch July 21, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nktks @hengfengli @olavloite @kokoro-team