feat(pubsub): expose CallOptions for pub/sub retries and timeouts #4428
+193
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
broady
reviewed
Aug 6, 2021
|
|
||
| // mergePublisherCallOptions merges two PublisherCallOptions into one and the first argument has | ||
| // a lower order of precedence than the second one. If either is nil, return the other. | ||
| func mergePublisherCallOptions(a *vkit.PublisherCallOptions, b *vkit.PublisherCallOptions) *vkit.PublisherCallOptions { |
There was a problem hiding this comment.
I think you could write a generic "merge two structs of the same type" function, but this works fine. 👍
broady
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar vein to the spanner PR (#2599), this PR allows users to specify their own retry / timeout configurations for clients for the high level manual library. Default topic/subscription configs are configured in all the GAPIC libraries and are exposed there (
cloud.google.com/go/pubsub/apiv1), but currently cannot be configured in the handwritten/manual library. This differs from the Spanner PR in that Pub/Sub requires specifying the publisher and subscriber options separately, requiring separate helper functions. Otherwise these functions are functionally identical to spanner.Closes #4162