Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery/storage/managedwriter): add state tracking #4407

Merged

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Jul 9, 2021

This PR introduces two new types:

AppendResult - tracks the progress of an individual row append to
completion, either success or error. Successful appends may have
an associated offset, failed appends will have an associated error.
The AppendResult has a blocking method users can interrogate.

pendingWrite - handles the state management for a set of rows appended
as a group. There's a 1:many relationship between
pendingWrite:AppendResult(s), so as a pendingWrite completes all
associated AppendResult references should be updated.

Towards: #4366

This PR introduces two new types:

AppendResult - tracks the progress of an individual row append to
completion, either success or error.  Successful appends _may_ have
an associated offset, failed appends will have an associated error.
The AppendResult has a blocking method users can interrogate.

pendingWrite - handles the state management for a set of rows appended
as a group.  There's a 1:many relationship between
pendingWrite:AppenResult(s), so as a pendingWrite completes all
associated AppendResult references should be updated.
@shollyman shollyman requested a review from a team as a code owner July 9, 2021 21:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jul 9, 2021
@shollyman shollyman requested a review from codyoss July 9, 2021 21:57
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments

bigquery/storage/managedwriter/appendresult.go Outdated Show resolved Hide resolved
@shollyman shollyman requested a review from codyoss July 12, 2021 18:23
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have one small comment to consider.

@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Jul 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4638e17 into googleapis:master Jul 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants