feature(bigquery/storage/managedwriter): add flow controller #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR basically cribs the flow controller code from pubsub, modulo some minor changes. Managed writer needs to do the same management of traffic on a streaming rpc channel, though in this case we'll be dealing with row appends / responses, whereas in pubsub its messages and acknowledgements.
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
codyoss
requested changes
Jul 9, 2021
codyoss
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically cribs the flow controller code from pubsub, modulo
some minor changes. Managed writer needs to do the same management
of traffic on a streaming rpc channel, though in this case we'll be
dealing with row appends / responses, whereas in pubsub its messages
and acknowledgements.
Toward: #4366