Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner/spansql): support ALTER DATABASE #4403

Merged
merged 6 commits into from Jul 12, 2021
Merged

feat(spanner/spansql): support ALTER DATABASE #4403

merged 6 commits into from Jul 12, 2021

Conversation

olavloite
Copy link
Contributor

Adds support for ALTER DATABASE dbname SET OPTIONS (..) statements.

Resolves #4390

@olavloite
feat(spansql): support ALTER DATABASE
ada8f61 
Adds support for ALTER DATABASE dbname SET OPTIONS (..) statements.

Resolves #4390
@olavloite
fix: variable names
d11159e
@olavloite olavloite requested a review from hengfengli July 9, 2021 06:59
@olavloite olavloite requested review from skuruppu and a team as code owners July 9, 2021 06:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jul 9, 2021
hengfengli
hengfengli requested changes Jul 11, 2021
View reviewed changes
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making this change. Just left a few comments.

@olavloite
Copy link
Contributor Author

LGTM. Thanks for making this change. Just left a few comments.

Thanks for the review. I've addressed / answered your comments. PTAL.

@hengfengli hengfengli changed the title feat(spansql): support ALTER DATABASE feat(spanner/spansql): support ALTER DATABASE Jul 12, 2021
@hengfengli hengfengli merged commit 1458dc9 into master Jul 12, 2021
@hengfengli hengfengli deleted the spansql-alter-database branch July 12, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner/spansql: Support ALTER DATABASE (SET OPTIONS) statements
2 participants
@olavloite @hengfengli