Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable/bttest): Emulator too lenient for empty RowMutation #4359

Merged
merged 19 commits into from Jul 27, 2021

Conversation

jimfulton
Copy link
Contributor

Fixed: #4309

@jimfulton jimfulton requested review from crwilcox, kolea2, tritone and a team as code owners June 30, 2021 21:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 30, 2021
Copy link
Contributor

@garye garye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from bigtable side

@jimfulton
Copy link
Contributor Author

Looks good from bigtable side

Thanks for the look!

(For some reason, I'm not getting notified for comments on my PRs. :/)

@jimfulton
Copy link
Contributor Author

@tritone I'm not worthy to merge. Can you?

@jimfulton jimfulton requested a review from a team as a code owner July 27, 2021 11:32
@crwilcox
Copy link
Contributor

@jimfulton seems a merge conflict arose. Can you address?

@jimfulton
Copy link
Contributor Author

@jimfulton seems a merge conflict arose. Can you address?

On it!

@jimfulton
Copy link
Contributor Author

@jimfulton seems a merge conflict arose. Can you address?

On it!

Done

@crwilcox crwilcox merged commit 35ceae2 into googleapis:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigtable/bttest: Emulator too lenient for empty RowMutation
4 participants