feat(firestore): Support DocumentRefs in OrderBy, Add Query.Serialize, Query.Deserialize for cross machine serialization #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
There was a problem hiding this comment.
I think your life would be simpler if you changed the Query class to be backed by Protos. Inspiration: https://github.com/googleapis/java-firestore/blob/9ff2f41b765c8878c3b3fb7df962f6f1ed537f05/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java#L234
crwilcox
force-pushed
the
query-serialization
branch
from
33a6f53
to
b9ad354
Compare
…e source of truth
crwilcox
force-pushed
the
query-serialization
branch
from
a77503f
to
10d797c
Compare
crwilcox
commented
Jul 15, 2021
crwilcox
commented
Aug 19, 2021
tritone
reviewed
Aug 31, 2021
tritone
reviewed
Aug 31, 2021
tritone
approved these changes
Sep 1, 2021
crwilcox
changed the title
crwilcox
changed the title
…d-go into query-serialization
crwilcox
changed the title
tritone
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the internal workings of query to store things in a proto representation. I wanted to do this for start/end cursors, but due to the allowing of order to happen after startat, it isn't feasible. There is a bug #4448 to track making a breaking change that would allow simplifying the cursors. See d4f34b0 for that approach (it is untidy, but should be functional)
This also enables serialization to proto which should make it possible for users to stream the query on another machine/process.
Also extended orderby to support document refs, a long todo that needed to be implemented to support round tripping.