Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsublite)!: hide CreateSubscriptionOption.apply #4344

Merged
merged 1 commit into from Jun 29, 2021
Merged

fix(pubsublite)!: hide CreateSubscriptionOption.apply #4344

merged 1 commit into from Jun 29, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 29, 2021

Since the createSubscriptionSettings struct is not exposed, hide the apply() func.

@tmdiep tmdiep requested review from a team as code owners June 29, 2021 22:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2021
@tmdiep tmdiep mentioned this pull request Jun 29, 2021
Closed
@tmdiep tmdiep merged commit f31fac6 into googleapis:master Jun 29, 2021
@tmdiep tmdiep deleted the create_subs_opt branch June 29, 2021 23:04
@yoshi-code-bot yoshi-code-bot mentioned this pull request Jun 29, 2021
Closed
@yoshi-code-bot yoshi-code-bot mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmdiep @hannahrogers-google