fix(pubsub): retry GOAWAY errors #4313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
hongalex
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tmdiep
approved these changes
Jun 29, 2021
pubsub/service.go
Outdated
| @@ -62,6 +62,14 @@ func (r *defaultRetryer) Retry(err error) (pause time.Duration, shouldRetry bool | |||
| return r.bo.Pause(), true | |||
| } | |||
| return 0, false | |||
| case codes.Unknown: | |||
| // Retry GOAWAY, see https://github.com/googleapis/google-cloud-go/issues/4257. | |||
| isGoaway := strings.Contains(s.Message(), "closing error reading from server: EOF") && | |||
There was a problem hiding this comment.
Just checking: does the error message contain exactly "closing error reading from server..."? I looked at the linked issue and that phrase isn't prefixed by "closing", so it may not match.
…go into fix-pubsub-goaway
hongalex
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend server for Pub/Sub might occasionally emit GOAWAY errors which are currently not retried. This is not unique to the Go client, though the categorization as
UNKNOWNvsUNVAILABLEis a golang-GRPC issue. Although UNKNOWN should not generally be retried, this will unblock users ofReceiveuntil the grpc library can be changed. See internal cl/377393940 for a similar fix in another Go library.Fixes #4257.