Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsublite): promote pubsublite to stable #4301

Merged
merged 4 commits into from Jul 8, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 23, 2021

Remove comments about Beta status from docs.

Release-As: 1.0.0

@tmdiep tmdiep requested review from a team as code owners June 23, 2021 00:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Jun 23, 2021
@tmdiep tmdiep requested review from codyoss and tbpg June 23, 2021 00:31
@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2021
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will probably need to update the following too, if someone else could comment:

// Update to "ga" after the manual client (beta) for pubsublite is released.
// Also make sure the manual client is generated in .repo-metadata-full.json.
releaseLevel: "beta",

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tmdiep
Copy link
Contributor Author

tmdiep commented Jul 8, 2021

@anguillanneuf Thanks for pointing that out, Tianzi. I'll update after the v1.0 release.

@tmdiep tmdiep merged commit c841d7f into googleapis:master Jul 8, 2021
@tmdiep tmdiep deleted the promote_stable branch July 8, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants