Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): fixes for background partition count updates #4293

Merged
merged 4 commits into from Jun 22, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 22, 2021

  • When refreshing topic partition counts in the background for Publishers, retry slowly upon resource exhausted errors. The last gax.Retryer found in call options is used, so we introduce a compositeRetryer for error codes with different backoff params.
  • partitionCountWatcher ignores errors after the first update. This is consistent with implementations in the Lite Java and Python client libraries.

@tmdiep tmdiep requested review from a team as code owners June 22, 2021 05:43
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Jun 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
pubsublite/internal/wire/rpc.go Outdated Show resolved Hide resolved
@tmdiep
Copy link
Contributor Author

tmdiep commented Jun 22, 2021

Thanks both for the review.

@tmdiep tmdiep merged commit 634847b into googleapis:master Jun 22, 2021
@tmdiep tmdiep deleted the topic_partitions_backoff branch June 22, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants